fixing pwsh syntax for signing

[alirana01]

Summary by CodeRabbit

• Chores
  • Improved build process security: Updated the automated Windows certificate signing workflow with enhanced validation for signing credentials and a safer parameterized approach for certificate conversion operations.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The CI release workflow's Windows signing flow is modified to replace a direct PowerShell keytool invocation with a parameterized approach. Changes include input validation requiring JKS_PASS and PFX_PASS to be at least 6 characters, dynamic keytool path variable creation, argument array construction, and parameter-driven execution instead of inline arguments, with post-step verification of cert.pfx creation.

Changes

Cohort / File(s)	Change Summary
Windows Keytool Invocation Parameterization .github/workflows/ci_release.yml	Replaces static keytool invocation with parameterized approach: adds input validation (minimum 6-char password requirement), builds dynamic keytool path variable, constructs argument array for importkeystore operation, executes via argument array, maintains post-step cert.pfx creation verification.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The change is focused on a single CI workflow file with a clear pattern: replacing direct command invocation with parameterized execution and adding input validation. While security-sensitive (password handling), the scope is narrow and the modifications follow a straightforward refactoring pattern.

Possibly related PRs

• Fixing ci signing for windows #1330: Modifies the same Windows CI keystore conversion flow in .github/workflows/ci_release.yml, adjusting keytool invocation and PFX password handling.
• IEP-1475: Signing Windows Executable #1228: Modifies the Windows signing flow in .github/workflows/ci_release.yml for JKS-to-PFX keytool conversion and related signing steps.
• fix: Dynamic discovery of of signtool.exe #1328: Replaces hardcoded tool invocations with dynamically discovered/parameterized executable paths in .github/workflows/ci_release.yml Windows signing steps (using signtool similarly to this PR's keytool approach).

Suggested reviewers

• kolipakakondal
• sigmaaa

Poem

🐰 The keytool now speaks with safer tongue,
Passwords validated, arguments strung,
No more inline commands in the raw,
Parameterized paths enforce the law! 🔐

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch IEP-1647-upd

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8cb4ea9 and c2a838e.

📒 Files selected for processing (1)

• .github/workflows/ci_release.yml (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}