WIP: feat: trying to customize p2 metadata#1413
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis pull request updates the Espressif IDF feature's build configuration and adds P2 metadata. It modifies the build properties file to include p2.inf in the distributed artifacts and creates a new p2.inf configuration file specifying Eclipse Metadata and Artifact repositories for 2025-12 as silent dependencies. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@releng/com.espressif.idf.update/p2.inf`:
- Around line 7-9: The property repository.references.2.options currently has a
trailing "s" making the value "1s" which is invalid; update
repository.references.2.options to the integer value "1" (remove the stray "s")
so the p2 repository options parse correctly, ensuring the change is made where
repository.references.2.options is defined in the p2.inf content.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 267de1b3-dc39-4fe8-a95e-e1425719224d
📒 Files selected for processing (1)
releng/com.espressif.idf.update/p2.inf
| repository.references.2.url=https://download.eclipse.org/releases/2025-12/ | ||
| repository.references.2.type=1 | ||
| repository.references.2.options=1s |
There was a problem hiding this comment.
Typo in options value: 1s should be 1.
The options property expects an integer value. The trailing s appears to be a typo and may cause parsing errors or unexpected behavior during p2 repository resolution.
🐛 Proposed fix
# Add the Eclipse 2025-12 Artifact Repository as a silent dependency
repository.references.2.url=https://download.eclipse.org/releases/2025-12/
repository.references.2.type=1
-repository.references.2.options=1s
+repository.references.2.options=1📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| repository.references.2.url=https://download.eclipse.org/releases/2025-12/ | |
| repository.references.2.type=1 | |
| repository.references.2.options=1s | |
| repository.references.2.url=https://download.eclipse.org/releases/2025-12/ | |
| repository.references.2.type=1 | |
| repository.references.2.options=1 |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@releng/com.espressif.idf.update/p2.inf` around lines 7 - 9, The property
repository.references.2.options currently has a trailing "s" making the value
"1s" which is invalid; update repository.references.2.options to the integer
value "1" (remove the stray "s") so the p2 repository options parse correctly,
ensuring the change is made where repository.references.2.options is defined in
the p2.inf content.
1 participant
Description
Please include a summary of the change and which issue is fixed.
Fixes # (IEP-XXX)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit