Conversation
We've observed issues with the the conditional discovery logic for all the `activity_foobar` bindings. It's not reliable, so sometimes these bindings are discovered and sometimes they aren't. If these bindings disappear when they were disabled then are re-discovered later as enabled, that could blow up certain API limits. To avoid that, I'm choosing to only enable the bindings that are consistently discovered, and the remaining conditionally discovered bindings are disabled.
Alex-Bair
deleted the
bair/source-marketo-conditionally-discover-bindings-as-disabled
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've observed issues with the conditional discovery logic for all the
activity_foobarbindings. It's not reliable, so sometimes these bindings are discovered and sometimes they aren't. If these bindings disappear when they were disabled then are re-discovered later as enabled, that could blow up certain API limits. To avoid that, I'm choosing to only enable the bindings that are consistently discovered, and the remaining conditionally discovered bindings are disabled.Tested on a local stack and confirmed that all the
activity_foobarbindings are discovered as disabled.