Conversation
Updating the node action Marking new devEngine props
travjenkins
added
dependencies
upgrades we need to do. Updating allowed license versions Removing the user of a dropzone as that will cause issue for now
Adding in the ManualTypedPostgrestResponse to handle hacky work around
| useBindingsEditorStore_populateSkimProjectionResponse(); | ||
| const editModeEnabled = useBindingsEditorStore_editModeEnabled(); | ||
| const disableSchemaEditing = useDisableSchemaEditing(); | ||
| const formActive = useFormStateStore_isActive(); |
There was a problem hiding this comment.
Need to disable editor when active as this was allowing edits to look saved even though they were not.
| /> | ||
| </Stack> | ||
| </StyledEngineProvider> | ||
| <Stack sx={{ ...jsonFormsPadding }}> |
There was a problem hiding this comment.
Cleaning up this provider as I think it was left over cruft from the past when JsonForms included different MUI version
| } | ||
| details={ | ||
| <BindingsEditor itemType={itemType} readOnly={readOnly} /> | ||
| <ErrorBoundryWrapper> |
There was a problem hiding this comment.
This made debugging easier and on the off chance it happens - I think it makes for a better UX.
Did not wrap the list as if that crashes this entire section is not safe to use.
There was a problem hiding this comment.
Was not 100% required - but a cleanup that helps a tiny bit.
| ...(variantString === 'standard' | ||
| ? { disableUnderline: true } | ||
| : {}), |
There was a problem hiding this comment.
This fixed the annoying issue on the dialog where it complained disableUnderline was getting on the component.
| const theme = useTheme(); | ||
|
|
||
| let ButtonComponent: (props: ProviderButtonProps) => EmotionJSX.Element, | ||
| let ButtonComponent: (props: ProviderButtonProps) => ReactElement, |
There was a problem hiding this comment.
Not referencing Emotion directly anymore
… this would override the user's settings. Now we only store this if the value was to change.
travjenkins
changed the title
node to v22 and npm to 11node to v22 and npm to 10
1 participant
Issues
NPM/Node - #1882
MUI - #1880
React 18 - #1584
Changes
NPM/Node
package.jsonto mark new versionsdevEnginesas this helps empower thenodeGitHub action cacheReact
Migration Guide
codemodmigrationStrictModeas out hydration does not work with itIS_REACT_ACT_ENVIRONMENTfor testingZustand
Migration Guide
useShallowor removed single item arrays (infinite loading)objectandarraysasconst(infinite loading)persistmanuallyDekafloads in the endpoint configpersistsetMUI
Migration Guide V6
Migration Guide V7
codemodmigration for V6 and V7 (in order)SafeLoadingButtonGrid(sizing and growth)slotPropskeyespecially when spreading propsEmotiondirectly anymoreJsonForms
Hiddencomponentmulti line secretdate,time, anddate-timepickersMisc (unrelated to upgrade)
StyledEngineProviderdocsfor the application - mainly targeting LLMsTests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
React
Updating the typing (no major impact)
MUI
Date / Time
Time
DateTime
Icons
File Upload
Removed old dependency and replace with new in-house one
Keyboard interactive
Now has a "loading" status while uploading the file (might need CPU throttle to test)
