Add Azure identity fields to data plane details popup#1918
Draft
GregorShear wants to merge 1 commit intomainfrom
Draft
Add Azure identity fields to data plane details popup#1918GregorShear wants to merge 1 commit intomainfrom
GregorShear wants to merge 1 commit intomainfrom
Conversation
083851f to
58d3f2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1917
Summary
azure_application_nameandazure_consent_linktoBaseDataPlaneQueryand the Supabase column queryToggleField— tab is automatically hidden whenazure_application_nameisnull(no 'not available' placeholder, matching the acceptance criterion to hide the tab when unconfigured)DataPlaneDialogFieldfor the consent link with a copy button, shown only whenazure_consent_linkis non-nulldata.azureApplicationNameanddata.azureConsentLinkNotes for backend
The
azure_consent_linkfield is assumed to be stored directly ondata_planes. If it ends up being derived from aazure_client_idor similar, only the column name inCOLUMNSandBaseDataPlaneQueryneed updating — the UI logic is the same either way.Test plan