feat(provers): Add optional cycle tracking to proving report#358
Open
Andrurachi wants to merge 1 commit into
Open
feat(provers): Add optional cycle tracking to proving report#358Andrurachi wants to merge 1 commit into
Andrurachi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #28.
Updates
ProgramProvingReportto track cycle counts during proving mode.execution_durationwas omitted because no current zkVM SDK cleanly separates or exposes internal execution time during aprove()call (due to fused/black-box trace generation pipelines).Changes:
core: Addedtotal_num_cycles: Option<u64>toProgramProvingReport.risc0: Populated cycles via the exposedprove_info.stats.total_cycles.airbender: Extracts cycles directly from the GPU prover'sProveResult. (The interpreter's pre-flight pass is not timed to emulate execution_duration. Execution is fused into the proving pipeline, making pre-flight timing an inaccurate reflection of actual proving-phase execution.sp1/openvm/zisk: Default toNone. Their respective SDKs drop or hide execution metrics during proving, returning only the final proof artifacts. (To get cycles for these,execute()must be call prior toprove()).