-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add Codex plugin support (skills + MCP only) #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Decision: Codex 호환은 skills/MCP만 지원 | ||
|
|
||
| **Decision**: Codex 플러그인 지원 범위를 skills와 MCP 서버로 한정하고, hooks/agents/commands는 Claude Code 전용으로 유지한다. | ||
|
|
||
| **Context**: skill-set 플러그인을 OpenAI Codex에서도 사용할 수 있도록 확장하는 과정에서, 전체 기능(skills, agents, hooks, commands, MCP)을 모두 호환시킬지 범위를 결정해야 했다. Codex와 Claude Code는 hooks 이벤트 모델, agents 정의 형식(TOML vs 마크다운), commands 개념 유무 등에서 차이가 있다. | ||
|
|
||
| **Rationale**: hooks와 agents까지 Codex 포맷으로 별도 관리하면 중복 코드와 관리 포인트가 늘어나 유지보수가 불편해진다. Claude Code가 메인 플랫폼이므로 이를 기준으로 관리하고, Codex는 양쪽이 이미 동일한 포맷을 공유하는 skills와 MCP만 활용하는 것이 중복 최소화와 유지보수 편의성 측면에서 최선이다. `.codex-plugin/plugin.json` 파일 1개 추가만으로 구현 가능하다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "name": "skill-set", | ||
| "description": "Comprehensive productivity skills for coding agents — git workflow automation, code context understanding, peer LLM consulting, prose writing, and more.", | ||
| "version": "1.8.1", | ||
| "author": { | ||
| "name": "ether-moon" | ||
| }, | ||
| "license": "MIT", | ||
| "skills": "./skills/", | ||
| "mcpServers": "./.mcp.json" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the missing
[1.8.1]link reference at the bottom.This heading uses reference-style version notation (
[1.8.1]), but no matching link definition is present in the shown reference list. Add it for consistency with other releases.Suggested patch
+[1.8.1]: https://github.com/ether-moon/skill-set/releases/tag/v1.8.1🤖 Prompt for AI Agents