feat: add developing-test-first and driving-with-tests skills - #14
Merged
Conversation
Two new test discipline skills based on superpowers benchmark and report analysis: - developing-test-first: strict Red/Green/Refactor TDD enforcement with Iron Law, rationalization table, and anti-pattern reference - driving-with-tests: test strategy layer (Orient/Probe/Guard/Architecture) with test-design and probing references Updates AGENTS.md catalog and using-skill-set discovery entries.
📝 WalkthroughWalkthroughAdded two new testing-focused skills to the skill-set plugin— Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
plugins/skill-set/skills/developing-test-first/SKILL.md (1)
1-202: Trim main SKILL.md to stay under the 200-line cap.This file is slightly over the limit; move a small slice (e.g., part of rationalizations/checklist details) into
reference/anti-patterns.mdto stay within the repository convention.Based on learnings: "Keep main SKILL.md documentation under 200 lines with detailed content in separate reference files".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/skill-set/skills/developing-test-first/SKILL.md` around lines 1 - 202, The SKILL.md exceeds the 200-line cap; remove or relocate the verbose "Common Rationalizations" table and the "Verification Checklist" (or another similar-length section) from SKILL.md into reference/anti-patterns.md, add a short one-line pointer in SKILL.md referencing the new location (e.g., "See reference/anti-patterns.md for rationalizations and checklist"), and ensure SKILL.md content is trimmed to under 200 lines while leaving headings like "Red-Green-Refactor", "When to Use", and "Red Flags" intact; update any internal cross-references to point to reference/anti-patterns.md so nothing is broken.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/skill-set/skills/developing-test-first/reference/anti-patterns.md`:
- Around line 15-101: The Markdown file contains unlabeled fenced code blocks
(e.g., the blocks starting with "1. NEVER test mock behavior" and the "Gate
Function:" examples under Anti-Pattern 1/2/3/4) which trigger MD040; add a
language identifier like "text" to every triple-backtick fence in the file (all
occurrences covering the top list and each Gate Function / advice block) so they
read ```text ... ``` consistently to satisfy markdownlint.
In `@plugins/skill-set/skills/developing-test-first/SKILL.md`:
- Around line 165-202: Add a new "## Troubleshooting" section to SKILL.md (near
the existing "When Stuck" and "Verification Checklist" sections) that lists
common problems and concise solutions for this skill (e.g., failing tests,
environment/setup issues, flaky tests, dependency/mocking pitfalls), include
actionable steps and links to relevant docs like `reference/anti-patterns.md`,
and ensure entries reference the existing checklist items (e.g., "Every new
function/method has a test", "Flaky test") so readers can correlate
troubleshooting steps to verification criteria.
In `@plugins/skill-set/skills/driving-with-tests/SKILL.md`:
- Around line 20-158: Add a mandatory "## Troubleshooting" section to SKILL.md
(near the end, after "Reference") that lists common failure modes and actionable
fixes for this skill (e.g., test command not detected, pre-existing failing
tests, flaky tests, slow tests, and when tests are being weakened); use clear
headings and short bullet remedies (reproduce locally, check scripts like
package.json/pyproject.toml, run single tests, revert spec changes, add
retries/timeouts, document known test exclusions) and reference the required
skill tag `developing-test-first` where appropriate.
---
Nitpick comments:
In `@plugins/skill-set/skills/developing-test-first/SKILL.md`:
- Around line 1-202: The SKILL.md exceeds the 200-line cap; remove or relocate
the verbose "Common Rationalizations" table and the "Verification Checklist" (or
another similar-length section) from SKILL.md into reference/anti-patterns.md,
add a short one-line pointer in SKILL.md referencing the new location (e.g.,
"See reference/anti-patterns.md for rationalizations and checklist"), and ensure
SKILL.md content is trimmed to under 200 lines while leaving headings like
"Red-Green-Refactor", "When to Use", and "Red Flags" intact; update any internal
cross-references to point to reference/anti-patterns.md so nothing is broken.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 23208343-938b-4740-b6c0-4901a017cde3
📒 Files selected for processing (7)
AGENTS.mdplugins/skill-set/skills/developing-test-first/SKILL.mdplugins/skill-set/skills/developing-test-first/reference/anti-patterns.mdplugins/skill-set/skills/driving-with-tests/SKILL.mdplugins/skill-set/skills/driving-with-tests/reference/probing.mdplugins/skill-set/skills/driving-with-tests/reference/test-design.mdplugins/skill-set/skills/using-skill-set/SKILL.md
- Add text language identifiers to fenced code blocks in anti-patterns.md (MD040) - Add Troubleshooting sections to developing-test-first and driving-with-tests - Trim developing-test-first/SKILL.md under 200-line cap by relocating Common Rationalizations and Verification Checklist to reference/anti-patterns.md
Owner
Author
Review Feedback ResolvedAll 3 actionable CodeRabbit comments + 1 nitpick addressed in 6c140f2:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/skill-set/skills/developing-test-first/SKILL.md`:
- Around line 38-40: The unlabeled fenced code block containing the line "NO
PRODUCTION CODE WITHOUT A FAILING TEST FIRST" triggers markdownlint MD040; fix
it by adding a language identifier (e.g., change the opening triple backticks
from ``` to ```text) so the block is labeled and linting passes, updating the
fenced block around that exact line in SKILL.md.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 216a7e80-dc3b-48e9-9a47-fa7885e7fbee
📒 Files selected for processing (3)
plugins/skill-set/skills/developing-test-first/SKILL.mdplugins/skill-set/skills/developing-test-first/reference/anti-patterns.mdplugins/skill-set/skills/driving-with-tests/SKILL.md
✅ Files skipped from review due to trivial changes (1)
- plugins/skill-set/skills/driving-with-tests/SKILL.md
8 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design Decisions
Test plan
developing-test-firsttriggers on "write a failing test", "TDD", "test first"driving-with-teststriggers on "run tests first", "design test strategy"Summary by CodeRabbit