Make reviewer telemetry failures non-blocking

[ether-moon]

Summary

• Make automated reviewer telemetry collection best effort instead of a snapshot dependency.
• Preserve selected checks and unresolved actionable review threads as the authoritative completion inputs.
• Report unavailable telemetry explicitly without leaking optional API errors to successful command stderr.

Changes

• Isolate telemetry collection in a trap-safe subshell so failures cannot release the parent snapshot lock.
• Return telemetry_available:false and unavailable provider states when telemetry queries or normalization fail.
• Convert the malformed CodeRabbit fixture into a regression proving settled checks and threads still yield clean.

Test Plan

• plugins/skill-set/tests/test-pr-runner.sh
• plugins/skill-set/tests/test-shipping-pr-authorization.sh
• plugins/skill-set/tests/test-shipping-pr-happy-path-eval.sh
• plugins/skill-set/scripts/validate-references
• python3 /Users/ether/.codex/skills/.system/skill-creator/scripts/quick_validate.py plugins/skill-set/skills/shipping-pr
• bash -n plugins/skill-set/skills/shipping-pr/scripts/skill-set-pr plugins/skill-set/tests/test-pr-runner.sh

Summary by CodeRabbit

• Bug Fixes

  • Reviewer telemetry failures no longer interrupt polling or snapshot completion.
  • Malformed or unavailable telemetry is clearly reported while checks, timeouts, and blocked verdicts continue to work normally.
  • Snapshots now indicate when reviewer telemetry is unavailable and identify affected reviewers accordingly.

• Tests

  • Updated coverage confirms graceful handling of malformed reviewer API responses without failing the workflow.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d3ad1680-907c-49ea-bda0-8c7ef9dbafb3

📥 Commits

Reviewing files that changed from the base of the PR and between 85847cb and 6e9d8f0.

📒 Files selected for processing (3)

• plugins/skill-set/skills/shipping-pr/reference/polling.md
• plugins/skill-set/skills/shipping-pr/scripts/skill-set-pr
• plugins/skill-set/tests/test-pr-runner.sh

---

📝 Walkthrough

Walkthrough

The snapshot runner now collects reviewer telemetry on a best-effort basis. Telemetry failures mark reviewers as unavailable, set telemetry_available to false, and preserve the snapshot result. Persisted data, command output, documentation, and tests reflect this behavior.

Changes

Reviewer telemetry

Layer / File(s)	Summary
Optional telemetry collection and snapshot propagation plugins/skill-set/skills/shipping-pr/scripts/skill-set-pr	The runner isolates telemetry failures, records unavailable reviewer states, and exposes telemetry_available in persisted snapshots and command responses.
Graceful degradation contract and regression coverage plugins/skill-set/skills/shipping-pr/reference/polling.md, plugins/skill-set/tests/test-pr-runner.sh	Polling documentation states that telemetry remains observational. The malformed CodeRabbit response test expects a successful snapshot with unavailable telemetry.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SnapshotCommand
  participant TelemetryCollector
  participant CodeRabbitAPI
  participant SnapshotOutput
  SnapshotCommand->>TelemetryCollector: collect optional reviewer telemetry
  TelemetryCollector->>CodeRabbitAPI: query reviewer data
  CodeRabbitAPI-->>TelemetryCollector: valid or malformed response
  TelemetryCollector-->>SnapshotCommand: reviewer state and telemetry_available
  SnapshotCommand->>SnapshotOutput: persist and return snapshot data

Loading

Possibly related PRs

• ether-moon/skill-set#18: Extends the same shipping-pr polling flow and tests for optional reviewer telemetry.
• ether-moon/skill-set#27: Modifies reviewer telemetry and snapshot handling in the same runner and polling documentation.
• ether-moon/skill-set#28: Refactors the runner that this PR updates with optional telemetry collection.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: reviewer telemetry failures no longer block snapshot completion.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ether_karrot/fix-optional-reviewer-telemetry

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}