Skip to content

Increase shipping PR resolver cycle default - #38

Merged
ether-moon merged 2 commits into
mainfrom
ether_karrot/increase-shipping-resolver-cycles
Aug 5, 2026
Merged

Increase shipping PR resolver cycle default#38
ether-moon merged 2 commits into
mainfrom
ether_karrot/increase-shipping-resolver-cycles

Conversation

@ether-moon

@ether-moon ether-moon commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • increase the shipping PR resolver cycle default from 3 to 5
  • keep the runner fallback, skill documentation, and legacy command documentation aligned
  • cover the new default with a regression assertion

Test Plan

  • plugins/skill-set/tests/test-pr-runner.sh
  • plugins/skill-set/tests/test-shipping-pr-happy-path-eval.sh
  • plugins/skill-set/tests/test-authoring-skills.sh
  • plugins/skill-set/tests/test-packaging.sh
  • plugins/skill-set/scripts/validate-references
  • plugins/skill-set/scripts/validate-evals
  • plugins/skill-set/scripts/generate-inventory --check
  • bash -n plugins/skill-set/bin/skill-set-pr plugins/skill-set/tests/test-pr-runner.sh

Summary by CodeRabbit

  • Improvements
    • Increased the default resolver cycle limit from 3 to 5 for initialization and transition-time fallback handling.
    • Updated shipping workflow documentation to reflect the new default.
  • Tests
    • Added coverage confirming initialized runs use a default limit of 5 cycles.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ether-moon, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b8fbe9e-3883-4079-aea7-adfb6499044d

📥 Commits

Reviewing files that changed from the base of the PR and between 4fc0b5e and bdec596.

📒 Files selected for processing (4)
  • plugins/skill-set/commands/pr/ship.md
  • plugins/skill-set/skills/shipping-pr/SKILL.md
  • plugins/skill-set/skills/shipping-pr/scripts/skill-set-pr
  • plugins/skill-set/tests/test-pr-runner.sh
📝 Walkthrough

Walkthrough

The PR raises the default resolver cycle limit from 3 to 5 across runner initialization, fallback handling, shipping documentation, workflow configuration, and tests.

Changes

Resolver cycle defaults

Layer / File(s) Summary
Runtime defaults and validation
plugins/skill-set/bin/skill-set-pr, plugins/skill-set/tests/test-pr-runner.sh
The runner uses 5 resolver cycles during initialization and transition fallback. The default initialization test checks max_cycles == 5.
Documented workflow defaults
plugins/skill-set/commands/pr/ship.md, plugins/skill-set/skills/shipping-pr/SKILL.md
The shipping command and workflow documentation specify 5 resolver cycles.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: increasing the shipping PR resolver cycle default.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch ether_karrot/increase-shipping-resolver-cycles
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ether_karrot/increase-shipping-resolver-cycles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ether-moon
ether-moon merged commit b11847e into main Aug 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant