Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

Some RLPX handshake log messages are duplicated (e.g. HelloPacket to <node id>) #5572

@halfalicious

Description

@halfalicious

I'm testing #5568 and seeing some RLPX handshake messages being logged twice. For example:

DEBUG 04-14 21:58:07 p2p  rlpx   p2p.connect.egress: HelloPacket to ##a979fb57…@52.16.188.185:30303
DEBUG 04-14 21:58:07 p2p  rlpx   p2p.connect.egress: HelloPacket to ##865a6325…@52.176.100.77:30303
DEBUG 04-14 21:58:07 p2p  rlpx   p2p.connect.egress: HelloPacket to ##865a6325…@52.176.100.77:30303
DEBUG 04-14 21:58:07 p2p  rlpx   p2p.connect.egress: Frame header from ##a979fb57…@52.16.188.185:30303
DEBUG 04-14 21:58:07 p2p  rlpx   p2p.connect.egress: HelloPacket to ##158f8aab…@13.75.154.138:30303
DEBUG 04-14 21:58:07 p2p  rlpx   p2p.connect.egress: Frame header from ##865a6325…@52.176.100.77:30303
DEBUG 04-14 21:58:07 p2p  rlpx   p2p.connect.egress: Frame header from ##865a6325…@52.176.100.77:30303

I don't think this is a regression in the PR since the changes don't affect the logging logic.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions