Output ENR text representation in admin.nodeInfo RPC

[gumb0]

See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-778.md#text-encoding for the relevant part of ENR spec.

1. Adapt base64 encoding/decoding functions to support URL-safe encoding (basically use - instead of +, _ instead of / and don't pad with =)
   https://github.com/ethereum/aleth/blob/master/libdevcore/Base64.h

2. Add method to ENR class returning string with text form of ENR (serilize to RLP and base64-encode it)

3. Add enr field in the output of admin_net_nodeInfo

   aleth/libweb3jsonrpc/AdminNet.cpp

   Line 27 in 6890d9a

   Json::Value AdminNet::admin_net_nodeInfo(std::string const& _session)

   
   You'll need to extend dev::p2p::NodeInfo struct for that and fill it in the method Host::nodeInfo() with Host::enr().

[twinstar26]

Hey @gumb0 I am very much eager to provide a solution and have already figured out most of the things.
Just wanna know how do we serialize to RLP (any existing functions) or some method. Also if you could link some part of aleth where we have already used serialization to RLP that would be very helpful!!

[gumb0]

@twinstar26 ENR already has a method for that, you don't need to do it yourself

aleth/libp2p/ENR.cpp

Line 88 in 4946ed6

void ENR::streamRLP(RLPStream& _s) const

This is an example of using it:

aleth/libp2p/Host.cpp

Line 1039 in 4946ed6

enr().streamRLP(ret);

Basically it will be something like

RLPStream s;
enr.streamRLP(s);
auto data = s.out();