Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

Parse the "allowFutureBlocks" in a more flexible manner.#4105

Merged
chriseth merged 1 commit intodevelopfrom
makeFutureBlocksFlexible
Jun 1, 2017
Merged

Parse the "allowFutureBlocks" in a more flexible manner.#4105
chriseth merged 1 commit intodevelopfrom
makeFutureBlocksFlexible

Conversation

@chriseth
Copy link
Contributor

This is required for testing Solidity.

@codecov-io
Copy link

codecov-io commented May 31, 2017

Codecov Report

Merging #4105 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4105      +/-   ##
===========================================
- Coverage    65.43%   65.41%   -0.03%     
===========================================
  Files          301      301              
  Lines        22866    22867       +1     
===========================================
- Hits         14963    14958       -5     
- Misses        7903     7909       +6
Impacted Files Coverage Δ
libethereum/ChainParams.cpp 95.76% <100%> (+0.03%) ⬆️
test/tools/fuzzTesting/fuzzHelper.cpp 25.98% <0%> (-5.4%) ⬇️
libethashseal/EthashCPUMiner.cpp 88.23% <0%> (-2.95%) ⬇️
libp2p/Common.cpp 52.8% <0%> (+0.79%) ⬆️
libp2p/Host.cpp 73.41% <0%> (+1.05%) ⬆️

@chfast
Copy link
Member

chfast commented May 31, 2017

I don't understand why this is needed. This also means that 0 of "0" would represent true.
If you have a good reason go ahead and merge it, but it might hit us some day in the future.

@chriseth
Copy link
Contributor Author

chriseth commented Jun 1, 2017

We made a breaking change to how this string is parsed. Previously, the presence of the key in the json would activate the feature. This was changed to "the feature is active if the key is present in the json, but the json will not be parsed if the value is not a bool". Both are obivously wrong, so I changed it to "If the key is present and the value is a bool, its value determines whether the feature is active or not and if it not a bool, the feature is active regardless of the value". So this change improves backwards compatibility while also actually using the value supplied.
We could try parsing the string, but as there is no documentation or specification for the feature anyway, ...

@chriseth chriseth merged commit d4d96c0 into develop Jun 1, 2017
@axic axic deleted the makeFutureBlocksFlexible branch July 10, 2017 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants