You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 28, 2021. It is now read-only.
I don't understand why this is needed. This also means that 0 of "0" would represent true.
If you have a good reason go ahead and merge it, but it might hit us some day in the future.
We made a breaking change to how this string is parsed. Previously, the presence of the key in the json would activate the feature. This was changed to "the feature is active if the key is present in the json, but the json will not be parsed if the value is not a bool". Both are obivously wrong, so I changed it to "If the key is present and the value is a bool, its value determines whether the feature is active or not and if it not a bool, the feature is active regardless of the value". So this change improves backwards compatibility while also actually using the value supplied.
We could try parsing the string, but as there is no documentation or specification for the feature anyway, ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for testing Solidity.