This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Fix TransactionIsUnsigned on call with default from parameter#5512
Merged
chfast merged 2 commits intoethereum:masterfrom Mar 5, 2019
Merged
Fix TransactionIsUnsigned on call with default from parameter#5512chfast merged 2 commits intoethereum:masterfrom
chfast merged 2 commits intoethereum:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5512 +/- ##
==========================================
+ Coverage 61.87% 61.91% +0.03%
==========================================
Files 345 345
Lines 28716 28735 +19
Branches 3265 3265
==========================================
+ Hits 17767 17790 +23
+ Misses 9781 9778 -3
+ Partials 1168 1167 -1 |
chfast
suggested changes
Mar 5, 2019
Member
chfast
left a comment
chfast
left a comment
There was a problem hiding this comment.
Excellent. Would you be able to reformat your unit test with clang-format?
Contributor
Author
|
Yes. Sure. I am sorry for that. |
Contributor
|
Thank you very much for this work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As written in https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_call there is an optional parameter "from". But if you make call without "from" and there are no keys in local wallet TransactionIsUnsigned exception is thrown because default sender value (zero address) in transaction confuse with no value.
I fixed this issue and added test to reproduce it.