This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Don't manually poll the ioservice after stopping capabilities#5533
Merged
Don't manually poll the ioservice after stopping capabilities#5533
Conversation
Manually polling the ioservice on shutdown is redundant. The motivation behind doing this was to ensure that the posted capability timer cancellations (see Host::stopCapabilities) were processed during host shutdown. However, it turns out that there's no need to do this because the capability timers only need to be cancelled if more capability work loops are being scheduled, but more capability work loops are only scheduled during shutdown if we are disconnecting pending handshakes and/or peers, each of which result in the io service being polled anyway.
halfalicious
requested review from
chfast and
gumb0
and removed request for
chfast
Codecov Report
@@ Coverage Diff @@
## master #5533 +/- ##
==========================================
- Coverage 61.87% 61.87% -0.01%
==========================================
Files 344 344
Lines 28756 28752 -4
Branches 3267 3264 -3
==========================================
- Hits 17792 17789 -3
- Misses 9796 9797 +1
+ Partials 1168 1166 -2 |
gumb0
reviewed
Mar 27, 2019
gumb0
approved these changes
Mar 27, 2019
chfast
suggested changes
Mar 27, 2019
Reference removal of ioservice polling and a message for the changes which fixed the capability timer race condition (#5523)
chfast
force-pushed
the
capability-ioservice-polling
branch
from
fd08e62 to
3c0c355
Compare
chfast
approved these changes
Mar 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually polling the ioservice on shutdown is redundant. The motivation behind doing this was to ensure that the posted capability timer cancellations (see Host::stopCapabilities) were processed during host shutdown (see #5523 for details). However, it turns out that there's no need to do this because the capability timers only need to be cancelled if more capability work loops are being scheduled, but more capability work loops are only scheduled during shutdown if we are disconnecting pending handshakes and/or peers, each of which result in the io service being polled anyway.