This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Removed --private option from aleth#5538
Merged
halfalicious merged 3 commits intoethereum:masterfrom Apr 1, 2019
twinstar26:master
Merged
Removed --private option from aleth#5538halfalicious merged 3 commits intoethereum:masterfrom twinstar26:master
halfalicious merged 3 commits intoethereum:masterfrom
twinstar26:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5538 +/- ##
==========================================
+ Coverage 61.88% 61.91% +0.02%
==========================================
Files 344 344
Lines 28769 28757 -12
Branches 3269 3267 -2
==========================================
+ Hits 17805 17806 +1
+ Misses 9795 9783 -12
+ Partials 1169 1168 -1 |
Contributor
|
Can you please update your PR description to mention the issue that you're fixing (and please be sure to include a "#" before the issue ID so that the issue is automatically updated with a link to this PR)? |
halfalicious
suggested changes
Mar 31, 2019
removed BadPrivateOption from enum AlethErrors as --private option has been removed from aleth
halfalicious
approved these changes
Apr 1, 2019
chfast
reviewed
Apr 1, 2019
|
|
||
| auto netPrefs = publicIP.empty() ? NetworkConfig(listenIP, listenPort, upnp) : NetworkConfig(publicIP, listenIP ,listenPort, upnp); | ||
| netPrefs.discovery = (privateChain.empty() && !disableDiscovery) || enableDiscovery; | ||
| netPrefs.discovery = !disableDiscovery; |
Member
There was a problem hiding this comment.
How do the options for enable/disable discovery look like now?
halfalicious
added a commit
that referenced
this pull request
Apr 2, 2019
PR 5538 removed the --private option from aleth
halfalicious
added a commit
that referenced
this pull request
Apr 2, 2019
PR 5538 removed the --private option from aleth
halfalicious
added a commit
that referenced
this pull request
Apr 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Name: Remove --private option from aleth #5531
--private option from aleth has been removed.