Documentation for creating a private network with 2 nodes#5546
Documentation for creating a private network with 2 nodes#5546halfalicious merged 12 commits intomasterfrom
Conversation
halfalicious
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5546 +/- ##
=========================================
+ Coverage 61.89% 61.9% +0.01%
=========================================
Files 344 344
Lines 28757 28757
Branches 3267 3267
=========================================
+ Hits 17800 17803 +3
Misses 9787 9787
+ Partials 1170 1167 -3 |
halfalicious
changed the title
|
Will squash all commits before merging |
gumb0
left a comment
gumb0
left a comment
There was a problem hiding this comment.
Looks great overall! Some minor notes/questions
| -------------------------- | ||
| For the purposes of this documentation, a **private network** can be thought of as a network of Ethereum nodes only accessible on your physical machine. | ||
|
|
||
| What is a Private Chain? |
There was a problem hiding this comment.
Did you mean to have both What is a Private Network? and What is a Private Chain? sections?
For the purposes of this documentation ... sentence is almost identical
There was a problem hiding this comment.
Yes, I meant to have both sections since I think a private network and a private chain are 2 distinct concepts (though they are frequently used together) - for example, you can run a private network with a mainnet chain config.
I've tweaked the verbiage in the "private chain" section so that it doesn't sound so similar to the previous section.
doc/private_net_sync.rst
Outdated
| Chain Configuration | ||
| ------------------- | ||
| - You typically initialize a private chain using a chain configuration json file (this isn't strictly required, but it makes testing a lot easier since you can do things like lower the difficulty rate and pre-fund addresses). | ||
| - The chain configuration json file format is defined here: https://github.com/ethereum/wiki/wiki/Ethereum-Chain-Spec-Format |
There was a problem hiding this comment.
Do we really follow that spec? It might be outdated.
There was a problem hiding this comment.
Good question! I assumed we did, Ill investigate
There was a problem hiding this comment.
You're right, the spec is either deprecated or we don't fully implement the spec (for example it lists a "nodes" key which we don't support). I'll remove the link.
doc/private_net_sync.rst
Outdated
| "allowFutureBlocks" : false | ||
| }, | ||
| "genesis": { | ||
| "nonce": "0x0000000000000042", |
doc/private_net_sync.rst
Outdated
| "gasLimit": "0x989680" | ||
| }, | ||
| "accounts": { | ||
| "0000000000000000000000000000000000000001": { "precompiled": { "name": "ecrecover", "linear": { "base": 3000, "word": 0 } }, "balance": "0x01" }, |
doc/private_net_sync.rst
Outdated
| "balance" : "0x2000000000000000000" | ||
| }, | ||
| "002c73acd4bc217998966964d27f0ee79a47befb": { | ||
| "balance" : "0x2000000000000000000" |
There was a problem hiding this comment.
I think it's not 2 ether, it's 0x2000000000000000000 wei (hex). Should be "balance" : "2000000000000000000"
There was a problem hiding this comment.
You are correct, typo on my part
doc/private_net_sync.rst
Outdated
|
|
||
| :: | ||
|
|
||
| Aleth -m on --config <file> -a <addr> --no-discovery --unsafe-transactions --listen <port> |
doc/private_net_sync.rst
Outdated
| { | ||
| "sealEngine": "Ethash", | ||
| "params": { | ||
| "accountStartNonce": "0x00", |
halfalicious
force-pushed
the
private-net-doc
branch
from
8dde76f to
48eead6
Compare
4 participants
No description provided.