Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

Minor network logging updates#5574

Merged
halfalicious merged 3 commits intomasterfrom
net-log-updates
Apr 26, 2019
Merged

Minor network logging updates#5574
halfalicious merged 3 commits intomasterfrom
net-log-updates

Conversation

@halfalicious
Copy link
Contributor

@halfalicious halfalicious commented Apr 23, 2019

@halfalicious halfalicious requested review from chfast and gumb0 April 23, 2019 04:42
@halfalicious
Copy link
Contributor Author

Same test is failing on linux & macos:

521 - network/net/packetsWithChangedEndpointSuite/neighbours (Failed)

Test is known to be unreliable (see #5544 ).

Full failure log:

Running 1 test case...
Test Case "neighbours": 
/home/builder/project/libdevcore/concurrent_queue.h(47): fatal error: in "_T dev::concurrent_queue<_T, _QueueT>::pop(const milliseconds&) [with _T = std::vector<unsigned char>; _QueueT = std::queue<std::vector<unsigned char>, std::deque<std::vector<unsigned char>, std::allocator<std::vector<unsigned char> > > >; std::chrono::milliseconds = std::chrono::duration<long int, std::ratio<1l, 1000l> >]": boost::exception_detail::clone_impl<dev::WaitTimeout>: /home/builder/project/libdevcore/concurrent_queue.h(47): Throw in function _T dev::concurrent_queue<_T, _QueueT>::pop(const milliseconds&) [with _T = std::vector<unsigned char>; _QueueT = std::queue<std::vector<unsigned char>, std::deque<std::vector<unsigned char>, std::allocator<std::vector<unsigned char> > > >; std::chrono::milliseconds = std::chrono::duration<long int, std::ratio<1l, 1000l> >]
Dynamic exception type: boost::exception_detail::clone_impl<dev::WaitTimeout>

/home/builder/project/test/unittests/libp2p/net.cpp(1253): last checkpoint: "neighbours" test entry

*** 1 failure is detected (5 failures are expected) in the test module "Master Test Suite"

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #5574 into master will decrease coverage by 0.03%.
The diff coverage is 65.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5574      +/-   ##
==========================================
- Coverage   62.11%   62.08%   -0.04%     
==========================================
  Files         347      347              
  Lines       29101    29038      -63     
  Branches     3299     3287      -12     
==========================================
- Hits        18077    18028      -49     
+ Misses       9843     9831      -12     
+ Partials     1181     1179       -2

@halfalicious halfalicious merged commit 6de1e88 into master Apr 26, 2019
@halfalicious halfalicious deleted the net-log-updates branch April 26, 2019 01:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use boost log attributes when logging RLPX handshake messages

3 participants