This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Add CMake option to disable building rocksdb (off by default)#5632
Merged
Add CMake option to disable building rocksdb (off by default)#5632
Conversation
chfast
requested review from
gumb0 and
halfalicious
and removed request for
gumb0
Codecov Report
@@ Coverage Diff @@
## master #5632 +/- ##
==========================================
+ Coverage 62.58% 62.78% +0.19%
==========================================
Files 350 348 -2
Lines 29734 29648 -86
Branches 3350 3341 -9
==========================================
+ Hits 18610 18615 +5
+ Misses 9911 9820 -91
Partials 1213 1213 |
gumb0
approved these changes
Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RocksDB support is now disabled by default. Enable with
-DROCKSB=ONCMake option.