interpreter: Fix call depth handling in CALLs

[chfast]

Fixes an issue in aleth-interpreter where for call the depth is not increased.
The additional assert now checks if the depth is the same as in ExtVM (will cause a lot of state test failures if the fix is not applied).

[codecov-io]

Codecov Report

Merging #5662 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #5662      +/-   ##
==========================================
- Coverage   62.79%   62.78%   -0.02%     
==========================================
  Files         349      349              
  Lines       29721    29723       +2     
  Branches     3346     3346              
==========================================
- Hits        18663    18661       -2     
- Misses       9845     9848       +3     
- Partials     1213     1214       +1

[gumb0]

I'm a bit confused about this

aleth/libethereum/ExtVM.cpp

Line 128 in d169557

Executive e{m_s, envInfo(), m_sealEngine, depth + 1};

EvmCHost::call delegates to ExtVM::call in the end, and there depth is incremented. Wouldn't it be then incremented twice with your fix?

[chfast]

ExtVM has it's own depth counter. We just check if both agree.

[gumb0]

Ok, I think I see. I guess it was working fine, because ExtVM was correctly counting anyway.

[chfast]

I guess it was working fine, because ExtVM was correctly counting anyway.

Exactly.