This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Initiate p2p disconnect when all capabilities are disabled#5675
Merged
halfalicious merged 2 commits intomasterfrom Jul 17, 2019
Merged
Initiate p2p disconnect when all capabilities are disabled#5675halfalicious merged 2 commits intomasterfrom
halfalicious merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5675 +/- ##
==========================================
+ Coverage 62.99% 63.01% +0.02%
==========================================
Files 350 350
Lines 29987 29955 -32
Branches 3360 3353 -7
==========================================
- Hits 18890 18877 -13
+ Misses 9880 9861 -19
Partials 1217 1217 |
gumb0
approved these changes
Jul 17, 2019
Also log the outgoing Disconnect p2p capability packet to the p2pcap logger rather than the net logger.
halfalicious
force-pushed
the
session-disconnect
branch
from
2d2b868 to
7bb270e
Compare
Contributor
Author
|
Rebased to fix changelog conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5674
Send out a p2p capability disconnect packet when all capabilities are disabled. Also log the outgoing Disconnect p2p capability packet to the
p2pcaplogger rather than thenetlogger.