Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

Enable optimizer in aleth-interpreter#5678

Merged
gumb0 merged 2 commits intomasterfrom
interpreter-optimizer
Jul 17, 2019
Merged

Enable optimizer in aleth-interpreter#5678
gumb0 merged 2 commits intomasterfrom
interpreter-optimizer

Conversation

@gumb0
Copy link
Member

@gumb0 gumb0 commented Jul 17, 2019

Similar to how LegacyVM enables it

if(EVM_OPTIMIZE)
target_compile_definitions(evm PRIVATE EVM_OPTIMIZE)
endif()

@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #5678 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5678      +/-   ##
==========================================
- Coverage   63.03%   62.98%   -0.06%     
==========================================
  Files         350      350              
  Lines       29952    29987      +35     
  Branches     3352     3360       +8     
==========================================
+ Hits        18880    18886       +6     
- Misses       9856     9882      +26     
- Partials     1216     1219       +3

@gumb0 gumb0 requested review from chfast and halfalicious July 17, 2019 10:41
CHANGELOG.md Outdated
- Fixed: [#5664](https://github.com/ethereum/aleth/pull/5664) Behavior in corner case tests about touching empty Precompiles now agrees with geth's results.
- Fixed: [#5662](https://github.com/ethereum/aleth/pull/5662) Correct depth value when aleth-interpreter invokes `evmc_host_interface::call` callback.
- Fixed: [#5666](https://github.com/ethereum/aleth/pull/5666) aleth-interpreter returns `EVMC_INVALID_INSTRUCTION` when `INVALID` opcode is encountered and `EVMC_UNKNOWN_INSTRUCTION` for undefined opcodes.
- Fixed: [#5678](https://github.com/ethereum/aleth/pull/5678) Enable optimizer in aleth-interpreter by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather make it Changed.

@gumb0 gumb0 force-pushed the interpreter-optimizer branch from e0b27d7 to 6750fd5 Compare July 17, 2019 12:28
@gumb0 gumb0 merged commit 0247ed2 into master Jul 17, 2019
@gumb0 gumb0 deleted the interpreter-optimizer branch July 17, 2019 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants