This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Upgrade Hunter to 0.23.211 to enable use of Visual Studio 2017#5719
Merged
Upgrade Hunter to 0.23.211 to enable use of Visual Studio 2017#5719
Conversation
Upgrade Hunter to 0.23.211 get YAML-CPP fix which enables use of Visual Studio 2017 to build Aleth. Notable package updates are: * YAML-CPP (0.6.2-p0 -> 0.6.2-p1) * ethash (0.4.4 -> 0.5.0)
halfalicious
force-pushed
the
upgrade-hunter
branch
from
33cc278 to
41883d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #5719 +/- ##
==========================================
- Coverage 63.11% 63.09% -0.02%
==========================================
Files 353 353
Lines 30193 30193
Branches 3386 3386
==========================================
- Hits 19056 19051 -5
- Misses 9901 9906 +5
Partials 1236 1236 |
chfast
approved these changes
Aug 19, 2019
Member
chfast
left a comment
chfast
left a comment
There was a problem hiding this comment.
Great. What was blocking VS 2017 before?
gumb0
approved these changes
Aug 19, 2019
Contributor
Author
@chfast Good question 😀 From #5516 (comment):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5516
Upgrade Hunter to get YAML-CPP fix which enables use of Visual Studio
2017 to build Aleth. Notable package updates are: