Implement EIP-152: Add Blake2 compression function F precompile by gumb0 · Pull Request #5751 · ethereum/aleth

gumb0 · 2019-09-19T16:19:29Z

https://eips.ethereum.org/EIPS/eip-152

codecov-io · 2019-09-19T17:09:19Z

Codecov Report

❗ No coverage uploaded for pull request base (master@7d82c60). Click here to learn what that means.
The diff coverage is 91.08%.

@@           Coverage Diff            @@
##             master   #5751   +/-   ##
========================================
  Coverage          ?   63.8%           
========================================
  Files             ?     358           
  Lines             ?   30604           
  Branches          ?    3403           
========================================
  Hits              ?   19526           
  Misses            ?    9848           
  Partials          ?    1230

gumb0 · 2019-09-20T16:01:03Z

libdevcrypto/Blake2.cpp

+    uint64_t w;
+    memcpy(&w, src, sizeof w);
+    return w;
+#else


@chfast Should we care about big endian platforms?

I don't think so.

chfast · 2019-09-23T12:36:42Z

libdevcrypto/Blake2.cpp


-    s.t[0] = load64(_t0.data());
-    s.t[1] = load64(_t1.data());
+    s.t[0] = *reinterpret_cast<uint64_t const*>(_t0.data());


These should stay load64 because otherwise this is undefined behavior if the memory is not aligned to 8 bytes.

chfast · 2019-09-23T12:37:32Z

libdevcrypto/Blake2.cpp

+    BLAKE2B_BLOCKBYTES = 128,
+};
+
+typedef struct blake2b_state__


Drop typedef.

chfast · 2019-09-23T12:37:41Z

libdevcrypto/Blake2.cpp

+
+enum blake2b_constant
+{
+    BLAKE2B_BLOCKBYTES = 128,


Convert to constexpr.

chfast · 2019-09-23T12:37:54Z

libdevcrypto/Blake2.cpp

+} blake2b_state;
+
+// clang-format off
+const uint64_t blake2b_IV[8] =


constexpr.

chfast · 2019-09-23T12:39:02Z

libdevcrypto/Blake2.cpp

+    return w;
+}
+
+inline uint64_t rotr64(const uint64_t w, const unsigned c) noexcept


Suggested change

inline uint64_t rotr64(const uint64_t w, const unsigned c) noexcept

inline constexpr uint64_t rotr64(uint64_t w, unsigned c) noexcept

chfast · 2019-09-23T12:40:52Z

libdevcrypto/Blake2.cpp

+{
+    uint64_t m[16];
+    uint64_t v[16];
+    size_t i;


Move i to loops.

gumb0 · 2019-09-23T13:55:20Z

libdevcrypto/Blake2.cpp

+
+#include <libdevcore/Exceptions.h>
+
+// The Blake 2 F compression function implemenation is based on the reference implementation,


@chfast do we need any kind of license note here?

It is not required because the reference implementation is in public domain, but I think it is nice to leave it here.

gumb0 · 2019-09-23T14:19:12Z

benchmarking test vectors from EIP (+ another one for 1200 rounds) currently looks like this to me

Running tests using path: "../../test/jsontests"
Running 1 test case...
Test Case "bench_blake2compression": 
bench_blake2compression/test4: 67 ns
bench_blake2compression/test5: 343 ns
bench_blake2compression/test6: 257 ns
bench_blake2compression/test7: 57 ns
bench_blake2compression/test_1200rounds: 18502 ns

Running tests using path: "../../test/jsontests"
Running 1 test case...
Test Case "bench_blake2compression_maxrounds": 
bench_blake2compression_maxrounds/test8: 66246045792 ns

gumb0 · 2019-09-23T15:30:25Z

This passes state tests from ethereum/tests#619, so I'm going to merge soon

gumb0 added the in progress label Sep 19, 2019

gumb0 added this to the Istanbul milestone Sep 19, 2019

Implement EIP-152: Add Blake2 compression function F precompile

ae4a739

gumb0 force-pushed the eip-152 branch from 8f6adbd to ae4a739 Compare September 19, 2019 16:21

gumb0 mentioned this pull request Sep 20, 2019

[META] Istanbul implementation #5716

Closed

18 tasks

Minor stylistic and formatting improvements

2f8e271

gumb0 commented Sep 20, 2019

View reviewed changes

Remove support for big endian platforms from blake2FCompression

797d8af

chfast suggested changes Sep 23, 2019

View reviewed changes

gumb0 added 3 commits September 23, 2019 15:03

Minor stylistic improvements in Blake2 precompile

9f3dd6b

Address review comments

5196341

Add comments

aae156c

gumb0 commented Sep 23, 2019

View reviewed changes

gumb0 added 2 commits September 23, 2019 16:04

Add Blake2 precompile to Istanbul test configs

0c1b87b

Move benchmarking max rounds into separate test case and add 1200 rounds

1c70934

Add changelog item

f2b08b7

gumb0 removed the in progress label Sep 23, 2019

chfast approved these changes Sep 23, 2019

View reviewed changes

gumb0 merged commit f57fa86 into master Sep 23, 2019

gumb0 deleted the eip-152 branch September 23, 2019 15:39

	inline uint64_t rotr64(const uint64_t w, const unsigned c) noexcept
	inline constexpr uint64_t rotr64(uint64_t w, unsigned c) noexcept


		#include <libdevcore/Exceptions.h>

		// The Blake 2 F compression function implemenation is based on the reference implementation,

Conversation

gumb0 commented Sep 19, 2019

Uh oh!

codecov-io commented Sep 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gumb0 commented Sep 23, 2019

Uh oh!

gumb0 commented Sep 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-io commented Sep 19, 2019 •

edited

Loading