This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Merged
Conversation
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #5867 +/- ##
==========================================
- Coverage 64.05% 63.99% -0.06%
==========================================
Files 364 364
Lines 30994 30970 -24
Branches 3435 3434 -1
==========================================
- Hits 19852 19819 -33
- Misses 9917 9921 +4
- Partials 1225 1230 +5 |
gumb0
suggested changes
Dec 10, 2019
Member
gumb0
left a comment
gumb0
left a comment
There was a problem hiding this comment.
We could make it better conform to Standard Readme by
- Adding short summary starting with
>before long description https://github.com/RichardLitt/standard-readme/blob/master/spec.md#short-description - Renaming
Getting Aleth-bootnodetoInstall - Adding
ContributingandLicensesections - those can just refer to existing files
Also I'm not sure about placing it in this folder, will anyone notice it there? Maybe the link from the big readme would help, yes.
Contributor
Author
|
@gumb0: Ah, didn’t realize there was a standard readme format. Will update with your suggestions |
halfalicious
force-pushed
the
bootnode-readme
branch
from
9d7f631 to
7264f29
Compare
gumb0
force-pushed
the
bootnode-readme
branch
from
d038f34 to
9c239ae
Compare
gumb0
approved these changes
Dec 11, 2019
Contributor
Author
|
@gumb0 Thanks for adding the rlp and testeth tools and updating the aleth-vm description! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5385
Add a README file for aleth-bootnode