Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fix for when localStorage is available but access is restricted#3031

Merged
nivida merged 4 commits intoweb3:1.xfrom
chaitanyapotti:1.x
Sep 11, 2019
Merged

Fix for when localStorage is available but access is restricted#3031
nivida merged 4 commits intoweb3:1.xfrom
chaitanyapotti:1.x

Conversation

@chaitanyapotti
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 16, 2019

Coverage Status

Coverage decreased (-0.1%) to 83.02% when pulling 626bcdc on chaitanyapotti:1.x into ce27738 on ethereum:1.x.

@miguelmota
Copy link

Great fix @chaitanyapotti! Hope this gets merged

@alcuadrado
Copy link

Hey @chaitanyapotti! Thanks for this PR.

Can you explain a little what it does, and especially, how (the error's checks)? It'd be great to have that info in the code.

@chaitanyapotti
Copy link
Contributor Author

@alcuadrado Here is the relevant documentation

@alcuadrado
Copy link

Thanks for that link @chaitanyapotti. Do you mind adding it as a comment in the function?

@nivida nivida removed the In Progress Currently being worked on label Sep 5, 2019
@nivida nivida merged commit 8574bd3 into web3:1.x Sep 11, 2019
@chaitanyapotti
Copy link
Contributor Author

@nivida Hey, any timeline on when this will be released?

@miguelmota
Copy link

Is this feature detection available in the latest npm package release yet?

@smithki
Copy link

smithki commented Oct 3, 2019

I'm wondering the same. Is there a timeline on this release? (or is it already available?)

EDIT: I confirmed for myself that the code is not yet released. This is blocking me on Brave support right now 😢

@miguelmota
Copy link

I ended up using ethers.js which is much more lightweight and doesn't have issues like this

@nivida nivida mentioned this pull request Oct 21, 2019
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Enhancement Includes improvements or optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants