Release - 1.2.2

[nivida]

Description

This release contains mostly back-ports from 2.x and some other improvements.

Added

• localStorage support detection added (Fix for when localStorage is available but access is restricted #3031)
• getNetworkType method extended with Görli testnet (feat(Network): add support for net id of Goerli #3095)
• supportsSubscriptions method added to providers (supportsSubscriptions method added to providers #3116)
• Add eth.getChainId method (Add eth.getChainId method to 1.x #3113)
• Minified file added to web3 package (Minified file added to web3 package  #3131)
• The transaction confirmation workflow can now be configured (The transaction confirmation workflow can now be configured #3130)
• Additional parameters for accounts.signTransaction added (docs) (eth.accounts.signTransaction method fixed #3141)
• Emit connected event on subscription creation (subscription.js Emit 'connected' event with subscription.id #3028)
• TypeScript type definitions added for all modules (Types back-port from 2.x with changes to match the 1.x logic #3132)
• Bloom filters added to web3.utils (feat: bring in ethereum-bloom-filters #3137)

Fixed

• Fix allow 0 as a valid fromBlock or toBlock filter param (fromBlock: 0 defaults to latest, fromBlock: 1 works correctly in eth.getPastLogs #1100)
• Fix randomHex returning inconsistent string lengths (web3.utils.randomHex does not produce consistent length strings #1490)
• Fix make isBN minification safe (isBN breaks in production #1777)
• Fix incorrect references to BigNumber in utils.fromWei and utils.toWei error messages (Utils functions mention BigNumber instead of BN in error messages #2468)
• Fix error incorrectly thrown when receipt.status is null (Possible incorrect parsing of receipt status #2183)
• Fix incorrectly populating chainId param with net_version when signing txs (Invalid chainId used to sign transactions #2378)
• regeneratorRuntime error fixed (web3.min.js: ReferenceError: regeneratorRuntime is not defined (v1.2.1) #3058)
• Fix accessing event.name where event is undefined (Accessing property name of undefined #3014)
• fixed Web3Utils toHex() for Buffer input (Web3Utils toHex/soliditySha3: Accept Buffer as input or throw error #3021)
• Fix bubbling up tx signing errors (Bubble up tx signing errors #2063, Bubble up tx signing errors #3105)
• HttpProvider: CORS issue with Firefox and Safari (CORS issue with 1.2.0 on Firefox and Safari #2978)
• Ensure the immutability of the tx object passed to function signTransaction (Function 'sendSignedTransaction' changes the value of the 'to' field from 'null' to '0x' #2190)
• Gas check fixed (Possible invalid gas check #2381)
• Signing issues Incorrect error from invalid private key for signTransaction #1998, Don't kill 1/2 bytes from private keys please #2033, and web3.eth.accounts.signTransaction produced errant bytecode #1074 fixed (Signing fixes back-ported from 2.x #3125)
• Fix hexToNumber and hexToNumberString prefix validation (Fix hexToNumber and hexToNumberString prefix validation #3086)
• The receipt will now returned on a EVM error (this got removed on beta.18) (receipt is missing on error event #3129)
• Fixes transaction confirmations with the HttpProvider (Fixes transaction confirmations with the HttpProvider #3140)

Compare View

v1.2.1 -> v1.2.2

Type of change

• Release

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no warnings.
• I have updated or added types for all modules I've changed
• Any dependent changes have been merged and published in downstream modules.
• I executed all the tests with success and extended the tests to cover all changes.
• I ran npm run build in the root folder and tested it in the browser and with node.
• I have tested all changes with an ethereum test network.

[nivida]

@cgewecke It would be great if you could check the draft release notes I've created. I have written some phrases about all important additions and improvements.

[coveralls]

Coverage remained the same at 84.005% when pulling 574ed91 on release/1.2.2 into b8f7185 on 1.x.

[joshstevens19]

Looks good, just a thought for next time, it probably would of been better to of merged every PR into the release/1.2.2 branch rather then directly into 1.x. Then this PR would of showed all the changes with the release notes.

Anyway looks good to merge 👍

[cgewecke]

Sweet! Release notes LGTM.

[alcuadrado]

Thanks for the work you all put into this :)

I just left two small comments on #3131 and #3116