This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fix hexToNumber and hexToNumberString prefix validation#3086
Conversation
cgewecke
changed the title
cgewecke
commented
Oct 3, 2019
cgewecke
commented
Oct 3, 2019
nivida
changed the title
Collaborator
Author
This was referenced Mar 31, 2020
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* fix hexToNumber & hexToNumberString prefix validation * CHANGELOG.md updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2184 in the 1.x branch by back-porting #2884.
Notes
PR fixes both
hexToNumberandhexToNumberString- fix(utils): hexToNumberString prefix validation #2884 only touchedhexToNumberString. Possible 2.x needs a small addition there.The existing
hexToNumbertests look like they were mistakenly copy-pasted fromhexToNumberStringso have amended those.