This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Conversation
nivida
approved these changes
Oct 8, 2019
Contributor
nivida
left a comment
nivida
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks! :)
cgewecke
approved these changes
Oct 8, 2019
Collaborator
cgewecke
left a comment
cgewecke
left a comment
There was a problem hiding this comment.
LGTM as well.
NB: eth.getChainId needs to be added to the documentation at some point.
Contributor
|
@cgewecke true that. It can be copied from the 2.x branch. @gabmontes Do you have the time to do this for us? |
This method was added to the branch 2.x in d98cef2. This change is to support the method in the 1.x line.
gabmontes
force-pushed
the
add-getchainid
branch
from
8a34697 to
9f6c813
Compare
Contributor
Author
|
@nivida added docs and rebased to get rid of the merge conflict. |
This was referenced Mar 31, 2020
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* Add eth.getChainId method This method was added to the branch 2.x in d98cef2. This change is to support the method in the 1.x line. * Updated changelog * Add eth.getChainId to the docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was added to the branch 2.x in d98cef2. This change is to support the method in the 1.x line.
Worth considering this PR in the discussion at #3070 .