test(eth): ensure wait_for_transaction_receipt accepts hex-string tx hash (success & timeout) (#2043)#3742
Open
tomonorisasaki wants to merge 2 commits intoethereum:mainfrom
Conversation
…hash (success & timeout) (ethereum#2043)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add regression tests to ensure
wait_for_transaction_receipt()accepts a transaction hash provided as a hex string, both on the success path and on the timeout path.What this does
TimeExhaustedis raisedWhy
Historically, passing a hex string could lead to a
TypeErrorin the timeout branch whereto_hexis called. These tests ensure the current behavior remains stable.Related Issue
Refs #2043
Notes
Happy to move/rename the test file if maintainers prefer a different location.