Skip to content

Add static methods for converting to and from wei with decimals#3769

Open
Roman505050 wants to merge 4 commits intoethereum:mainfrom
Roman505050:feature/add-wei-funcs
Open

Add static methods for converting to and from wei with decimals#3769
Roman505050 wants to merge 4 commits intoethereum:mainfrom
Roman505050:feature/add-wei-funcs

Conversation

@Roman505050
Copy link

@Roman505050 Roman505050 commented Oct 19, 2025

What was wrong?

Related to Issue #3768
Closes #3768

How was it fixed?

Add static methods for converting to and from wei with decimals

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

image

@fselmo
Copy link
Collaborator

fselmo commented Feb 3, 2026

@Roman505050 can you add some basic tests here to make sure it's wired up? No need to add too much as this is done in eth-utils but just in case we break the wiring up of the method, we should have a sanity check on it. If not, someone will get around to it soon. This is lower prio but I can get this in with a basic test... thanks for the PR :)

@Roman505050
Copy link
Author

@Roman505050 can you add some basic tests here to make sure it's wired up? No need to add too much as this is done in eth-utils but just in case we break the wiring up of the method, we should have a sanity check on it. If not, someone will get around to it soon. This is lower prio but I can get this in with a basic test... thanks for the PR :)

I think I can easily add a few basic tests, as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add static methods for converting to and from wei with decimals

2 participants