You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Roman505050 can you add some basic tests here to make sure it's wired up? No need to add too much as this is done in eth-utils but just in case we break the wiring up of the method, we should have a sanity check on it. If not, someone will get around to it soon. This is lower prio but I can get this in with a basic test... thanks for the PR :)
@Roman505050 can you add some basic tests here to make sure it's wired up? No need to add too much as this is done in eth-utils but just in case we break the wiring up of the method, we should have a sanity check on it. If not, someone will get around to it soon. This is lower prio but I can get this in with a basic test... thanks for the PR :)
I think I can easily add a few basic tests, as soon as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #3768
Closes #3768
How was it fixed?
Add static methods for converting to and from wei with decimals
Todo:
Cute Animal Picture