Fix Windows compatibility in test_package.py script#3804
Open
colloceo wants to merge 2 commits intoethereum:mainfrom
Open
Fix Windows compatibility in test_package.py script#3804colloceo wants to merge 2 commits intoethereum:mainfrom
colloceo wants to merge 2 commits intoethereum:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
test_package.pyscript had hardcoded Unix-style paths (bin/pip) that would fail on Windows systems. Additionally, the activation command message only showed Unix instructions, making it confusing for Windows users. The code also had duplication of the pip path logic betweencreate_venv()andinstall_wheel()functions, and used a genericExceptiontype instead of a more specific exception.Related to Issue # (leave blank if none)
Closes # (leave blank if none)
How was it fixed?
get_pip_exe()helper function to centralize platform-specific pip executable path detection (Windows:Scripts/pip.exe, Unix:bin/pip)create_venv()andinstall_wheel()to use the new helper function, eliminating code duplicationScripts\activate, Unix:source bin/activate)ExceptiontoValueErrorfor better error handling when multiple or no wheels are foundTodo:
Cute Animal Picture