This repository was archived by the owner on Jun 17, 2021. It is now read-only.
Merged
Conversation
Member
Author
|
Check won't pass because coverage doesn't upload? |
alcuadrado
previously approved these changes
Jul 31, 2020
Member
alcuadrado
left a comment
There was a problem hiding this comment.
LGTM. Makes sense not to create the strings if they aren't needed.
I don't know what's going on with the CI. I tried re-running it and it failed in another way.
Member
Author
|
@evertonfraga could you take a look why Upload to Coveralls is not working in the CI? 😄 |
Contributor
|
Sure, sir! |
evertonfraga
approved these changes
Jul 31, 2020
Contributor
evertonfraga
left a comment
There was a problem hiding this comment.
Done and fixed. Feel free to merge!
Contributor
|
The main reason was a command trying to fetch a SHA reference from git, when it didn't exist.
|
Member
Author
|
Thanks a lot @evertonfraga 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing Homestead in this PR I ran into an issue when trying to copy SHA3 large buffers which is caused by
assertIsBuffer. This copies Buffers with sizes which node cannot handle even if there are no errors:When you try to copy a Buffer into a string which is too large, it throws. Besides that, it does not make sense to create these messages if there are no errors (this is unnecessary copying).