This repository was archived by the owner on Jun 17, 2021. It is now read-only.
Add toBuffer() method to Address, make toBuffer() function convert TransformableToBuffer#277
Merged
Add toBuffer() method to Address, make toBuffer() function convert TransformableToBuffer#277
toBuffer() method to Address, make toBuffer() function convert TransformableToBuffer#277Conversation
holgerd77
force-pushed
the
tobuffer-improvements
branch
from
e7aa906 to
45512f8
Compare
Member
|
Rebased this and moved the interfaces mentioned (so: TransformableToArray and TransformableToBuffer) to |
holgerd77
approved these changes
Oct 7, 2020
Member
holgerd77
left a comment
holgerd77
left a comment
There was a problem hiding this comment.
Looks good, will merge and prepare a subsequent release PR.
| return Buffer.from(v.toBuffer()) | ||
| } | ||
|
|
||
| throw new Error('invalid type') |
Member
There was a problem hiding this comment.
Love this refactored and simplified code of the toBuffer method, also highly valuable to have proper input types here now. 😍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
toBuffer()method to Address, and makes the exportedtoBuffer()function additionally handle if the object has atoBuffer()method.This work was motivated by @jochem-brouwer's work in the block library refactoring (thread here).