This repository was archived by the owner on Jun 17, 2021. It is now read-only.
Update Account.isEmpty to be EIP-161 compliant / New v7.0.7 Release#279
Merged
Update Account.isEmpty to be EIP-161 compliant / New v7.0.7 Release#279
Conversation
Contributor
|
great, thanks for opening this! I have some housekeeping notes from working in the monorepo so I am added these to this PR as well:
|
jochem-brouwer
approved these changes
Oct 15, 2020
Member
jochem-brouwer
left a comment
jochem-brouwer
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fixes in this PR!
Member
Author
|
Just published as v7.0.7 on npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
Account.isEmpty()to beEIP-161compliant (thestateRootcheck is therefore removed) following the result of the discussion along theUtil.Accountintegration PR here within the VM and the monorepo libraries in general.