This repository was archived by the owner on Oct 30, 2024. It is now read-only.
Merged
Conversation
holgerd77
commented
Jun 23, 2020
| - Added org links and Git hooks, | ||
| PR [#88](https://github.com/ethereumjs/ethereumjs-wallet/pull/88) | ||
|
|
||
| [0.6.4]: https://github.com/ethereumjs/ethereumjs-wallet/compare/v0.6.3...v1.0.0 |
Member
Author
There was a problem hiding this comment.
Note: this compares to v0.6.3 since v0.6.4 is on another branch.
alcuadrado
reviewed
Jun 23, 2020
|
|
||
| The API of the library hasn't been changed intentionally but has become more strict on type input by the explcit type definitions from the `TypeScript` code in function signatures together with the introduction of the `ethereumjs-util` [v7](https://github.com/ethereumjs/ethereumjs-util/releases) library within the `Wallet` library, which behaves more strict on type input on the various utility functions. | ||
|
|
||
| This leads to cases where some input - while not having been the intended way to use the library - might have been worked before through implicit type conversion and is now not possible any more. |
Member
There was a problem hiding this comment.
I think "worked" should be "working" here
alcuadrado
approved these changes
Jun 23, 2020
Member
alcuadrado
left a comment
alcuadrado
left a comment
There was a problem hiding this comment.
Nice explanation of the api changes, @holgerd77 !
Member
Author
|
Just released as v1.0.0 on npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was a bit afraid of this release also from the release notes side, but I think I've now found a way documented the changes noteworthy to mention in a way I am really happy with! 😄
This is now open for review and we should be able to do a release tomorrow or Wednesday.