You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 30, 2024. It is now read-only.
This PR switches to babelified ES5 packaging. Tests are included in the babel build. For test run with the test script, distribution tests are used, coverage is using the original test files in the test folder.
ok but this way npm won't fetch and build the dist folder when using npm install ethereumjs-wallet in another project. or maybe you want to publish dists separately?
I have just tested this for another library (ethereumjs-util) to double-check, dist folder is actually included there when library is installed with npm.
The dist folder is included with the files directive in package.json, so it is distributed with the npm package, npm is ignoring .gitignore here. Do you have any other information beyond that I didn't consider here?
I also use ethereumjs-util and it's ok, in my node_modules there is a dist folder. but there is no dist folder in ethereumjs-wallet when fetching from github using npm. maybe there is a bug in npm that won't run build script for dependencies fetched from git. so if this is the case then yes this PR is ok IMO. thanks for your fast PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since topic also came up here:
This PR switches to babelified
ES5packaging. Tests are included in the babel build. For test run with thetestscript, distribution tests are used,coverageis using the original test files in thetestfolder.