This repository was archived by the owner on Oct 30, 2024. It is now read-only.
Accept the true range of addresses for ICAP direct#6
Merged
Conversation
axic
force-pushed
the
feature/less-strict-icap
branch
from
36fac5f to
9befab6
Compare
axic
force-pushed
the
feature/less-strict-icap
branch
from
9befab6 to
f5de70e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ICAP document describes direct addresses as <155 bits.
I think the largest 30 character ICAP is the following:
XE43ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZThis decodes to0x088f924eeceeda7fe92e1f5b0fffffffffffffffwhich is 156 bits.This PR takes anything
<= 0x088f924eeceeda7fe92e1f5b0fffffffffffffffas valid for ICAP Direct.The spec also says that "generally these addresses begin with a zero byte" - would some implementations take that as "must begin with zero byte"? If yes, the above code will not generate valid addresses.