This repository was archived by the owner on Oct 30, 2024. It is now read-only.
Conversation
| "name": "ethereumjs-wallet", | ||
| "version": "0.6.1", | ||
| "description": "Utilities for handling Ethereum keys", | ||
| "main": "dist/index.js", |
Contributor
There was a problem hiding this comment.
Alternatively, you could keep this as dist/index.js, build from src/ into dist/, and place a script/s that doesn't get transpiled by babel at the top-level of the package, e.g. hdkey.js:
module.exports = require('./dist/hdkey.js');For each module that people expect to be able to:
require('ethereumjs-wallet/<module>');
You would need a corresponding top-level script that's a one-liner re-export from the corresponding module in dist/.
holgerd77
force-pushed
the
fix-dist-import-issue
branch
from
f67de59 to
b4c1c2e
Compare
Member
Author
|
Have re-triggered the tests after an update to the coveralls command since this was still failing. |
holgerd77
commented
Aug 8, 2018
Member
Author
holgerd77
left a comment
holgerd77
left a comment
There was a problem hiding this comment.
Have looked at this again with a one-day-distance, will now merge since this is time-critical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution for #64