This repository was archived by the owner on Oct 30, 2024. It is now read-only.
Update package.json to include published files#67
Merged
holgerd77 merged 1 commit intoethereumjs:masterfrom Sep 24, 2018
Merged
Update package.json to include published files#67holgerd77 merged 1 commit intoethereumjs:masterfrom
holgerd77 merged 1 commit intoethereumjs:masterfrom
Conversation
Member
|
Hi @jwerle, I think I had a reason on adding the slash here. Can you please provide a list with the files added to a local package creation with and without the change? |
Contributor
Author
|
I'll make a reproduction case in a repository. In any case the file glob in
that array says match all .js files in the / directory which causes tools
like pkg who read that property to resolve incorrectly.
…On Fri, Aug 17, 2018, 05:22 Holger Drewes ***@***.***> wrote:
Hi @jwerle <https://github.com/jwerle>, I think I had a reason on adding
the slash here. Can you please provide a list with the files added to a
local package creation with and without the change?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZSvQiX3ZrSsRAKbX1nzbX6bXNsFz83ks5uRotrgaJpZM4V9VcW>
.
|
Contributor
Author
|
@holgerd77 Please see https://github.com/jwerle/pkg-ethereumjs-wallet-reproduction which contains two branches, one to show a failed run of
|
This was referenced Aug 17, 2018
holgerd77
approved these changes
Sep 24, 2018
Member
holgerd77
left a comment
There was a problem hiding this comment.
Ok, tested this locally with npm pack and then having a look at the generated tarball, package content stays the same. Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List the files that will be published to npm in the package.json so tools like pkg can correctly resolve files that are listed there.
Running
pkgwith any module that requiresethereumjs-walletwill result in the following error:Correcting
/*.jsto*.jsfixes this. 🙌