etherscan price in btc

[cryptofuture]

• Adds getEtherPriceBtc method

[ricmoo]

This is something that make more sense to add to an Ancillary package. The v5 branch makes it easier to create simple extensions for more specific purposes. I'll look this back in once I've committed the v5 branch into the repo.

[ricmoo]

Also, as a note, I plan to add general support to all providers for getPrice(), using the Maker gas price oracle, which will allow sub-providers to override the implementation (for example, Etherscan provides their own).

Any conversion to BTC can be done by another package which has reliable access to the BTC price. Or does anyone know of reliable oracles for that too?

[cryptofuture]

Also, as a note, I plan to add general support to all providers for getPrice(), using the Maker gas price oracle, which will allow sub-providers to override the implementation (for example, Etherscan provides their own).

Any conversion to BTC can be done by another package which has reliable access to the BTC price. Or does anyone know of reliable oracles for that too?

Basically cmc or coingecko (which api I prefer) already using median value, that is based on value from the different exchanges, but for ETH I'm using etherscan, since I prefer it for reliability.
But main point is are median values are really in fact reliable, if most time person anyway prefer only some exchanges or even takes local price in consideration.

[ricmoo]

I am going to push this off and close this issue. Please feel free to re-open if you would like to discuss further, but I think the price in BTC is too specific for this library.

An ancillary library can easily pull in the EtherscanProvider and use the provider.baseUrl if needed, although hardcoding the URL is likely easier and would reduce the need for ethers as a dependency.

Thanks! :)