Skip to content

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Jan 8, 2026

Ticket ENG-708

Description Of Changes

Migrates properties table, domain verification table, and messaging templates tables to Ant Design.

Code Changes

  • Table migrations
  • Refactored properties table to use custom table hook
  • Also migrated some misc Chakra components in those views

Steps to Confirm

  1. General regression/CI passes
  2. View tables, ensure data is shown with appropriate columns

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner January 8, 2026 16:18
@jpople jpople requested review from speaker-ender and removed request for a team January 8, 2026 16:18
@vercel
Copy link
Contributor

vercel bot commented Jan 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 13, 2026 4:30pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 13, 2026 4:30pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR successfully migrates three table views (properties, domain verification, and messaging templates) from Chakra UI to Ant Design, resulting in a net reduction of ~180 lines of code.

  • Extracted properties table logic into a new usePropertiesTable hook following the project's pattern for custom table hooks
  • Properly uses existing useTableState, useSearch, and usePagination hooks for URL state synchronization
  • Updated Cypress tests to work with new Ant Design table selectors
  • Renamed PropertyActions.tsx to PropertyActionsCell.tsx for clarity
  • Removed unused imports and simplified component structure
  • Added consistent sorting to messaging templates API response for predictable table ordering

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are well-structured UI migrations that follow established patterns in the codebase. The code properly uses existing hooks for state management (useTableState, useSearch, usePagination), maintains URL synchronization, and includes comprehensive test updates. Only one minor style improvement found.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/properties/PropertiesTable.tsx 5/5 Simplified component to use new custom hook, clean migration to Ant Design
clients/admin-ui/src/features/properties/usePropertiesTable.tsx 5/5 New hook extracted table logic, uses useTableState for URL state synchronization
clients/admin-ui/src/features/properties/PropertyActionsCell.tsx 4/5 Renamed from PropertyActions, uses Ant Design components instead of Chakra
clients/admin-ui/src/pages/notifications/templates/index.tsx 5/5 Migrated to Ant Design Table, uses useTableState hook for state management
clients/admin-ui/src/pages/settings/domain-records.tsx 5/5 Migrated to Ant Design Table, simplified component structure

Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment but otherwise looks good!
If the current design/behavior is correct I can approve.

@jpople jpople enabled auto-merge January 13, 2026 16:36
@jpople jpople added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit 23078ee Jan 14, 2026
45 checks passed
@jpople jpople deleted the jpople/eng-708/small-tables-migration branch January 14, 2026 13:58
mfbrown pushed a commit that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants