Make loader screen honor preferred color scheme#1037
Merged
Conversation
aine-etke
changed the title
aine-etke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when you opened Synapse Admin (especially for the first time), you would see an almost pure white screen with a spinner signaling that the app was loading. That screen did not respect the preferred color scheme and burned eyes for dark-scheme users.
This PR resolves that problem by introducing an automatic dark/light theme for the loader, based on the browser's preferred color scheme, similar to how the app itself behaves.
Also, this PR includes tricks to provide 2
manifest.jsons - one for the light theme (default), and another one for the dark theme. As browsers' adoption of proper<link rel="manifest">is not very good, additional JS hack is introduced to swap manifests depending on the preferred color scheme