Reorder DocClaims by issuer Metadata in toClaimsModel function#326
Merged
phisakel merged 1 commit intoeu-digital-identity-wallet:mainfrom Apr 17, 2026
Merged
Conversation
Add tests for CBOR docClaims order and include necessary resources - Implemented a new test `testCborDocClaimsRespectMetadataOrder` to verify that the order of document claims follows the metadata claim order. - Added `pid-demo-openid-credential-issuer.json` to provide issuer metadata for testing. - Created `pid_demo_current_doc_claims_order.json` to represent the current order of document claims for comparison in tests.
marinaioannou
approved these changes
Apr 17, 2026
phisakel
merged commit 93678ec
into
eu-digital-identity-wallet:main
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for CBOR docClaims order and include necessary resources
testCborDocClaimsRespectMetadataOrderto verify that the order of document claims follows the metadata claim order.pid-demo-openid-credential-issuer.jsonto provide issuer metadata for testing.pid_demo_current_doc_claims_order.jsonto represent the current order of document claims for comparison in tests.