Hibernate 5 Multitenancy tutorial by joshiparthin · Pull Request #1150 · eugenp/tutorials

joshiparthin · 2017-02-10T14:35:24Z

No description provided.

KevinGilmore

There are merge conflicts -- you'll need to pull in the latest changes from the main repo. Also I made a few notes in the pom.xml.

KevinGilmore · 2017-04-01T13:38:19Z

+			<version>6.0.5</version>
+		</dependency>
+		<dependency>
+            <groupId>com.h2database</groupId>


Adjust the indentation here -- looks like this one uses spaces and the others use tabs. Spaces are preferred, but the main point is to be consistent.

KevinGilmore · 2017-04-01T13:54:47Z

+		<dependency>
+			<groupId>org.hibernate</groupId>
+			<artifactId>hibernate-core</artifactId>
+			<version>5.2.6.Final</version>


Latest is 5.2.9.Final

KevinGilmore · 2017-04-01T13:55:13Z

+		<dependency>
+            <groupId>com.h2database</groupId>
+            <artifactId>h2</artifactId>
+            <version>1.4.193</version>


Latest is now 1.4.194

KevinGilmore · 2017-04-01T13:56:28Z

+			<version>4.12</version>
+		</dependency>
+		<!-- https://mvnrepository.com/artifact/com.fasterxml/classmate -->
+		<dependency>


Are you certain that all of these other dependencies are needed in order to use hibernate? Are they not brought in as transitive properties when you include hibernate-core in your POM? Let me know what you find.

Removed. Its working.

KevinGilmore · 2017-04-08T14:37:40Z

+ * Suppliers generated by hbm2java
+ */
+@Entity(name = "Supplier")
+@Table(name ="Suppliers")


Make table name "Supplier" also

KevinGilmore

Resolve merge conflicts

KevinGilmore · 2017-04-10T12:45:58Z

+        <module>hibernate5</module>
  </modules>

-</project>


There's a merge conflict with this file -- you'll need to update your branch from upstream, resolve the conflict(s), and do another push. Not sure what the problem is exactly -- could be as simple as restoring the empty line at the end of the file.

@KevinGilmore I think this is about parent pom.xml file. I've pulled, merged, resolved, commited and pushed. Let me know still if you are facing issues.

KevinGilmore

See individual files for details.

KevinGilmore · 2017-04-10T12:51:25Z

+            <version>4.12</version>
+        </dependency>
+
+        <dependency>


Do we still need the mysql library?

@KevinGilmore Done. Removed.

KevinGilmore · 2017-04-10T12:51:58Z

+            Session currentSession = sessionFactory.withOptions().tenantIdentifier("h2db1").openSession();
+            Transaction transaction = currentSession.getTransaction();
+            transaction.begin();
+//            currentSession.createSQLQuery("DROP ALL OBJECTS;").executeUpdate();


if we don't need this line, let's remove it

@KevinGilmore This class is not used in article. I have just taken here for testing the boostrapping of multitenancy. Let me know if you want me to delete it.

KevinGilmore · 2017-04-10T12:55:19Z

+"http://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd">
+<!-- Generated Feb 9, 2017 11:31:36 AM by Hibernate Tools 5.1.0.Final -->
+<hibernate-mapping>
+    <class name="com.baeldung.hibernate.pojo.Suppliers" table="suppliers" optimistic-lock="version">


Shouldn't this use "Supplier" for the POJO and "supplier" for the table name?

@KevinGilmore We have used entity classes mapping so this hbm is no more required. Earlier I tried it with hbm and thus this code was from that trial. We dont need this anymore and have removed in today's commits.

KevinGilmore · 2017-04-10T12:55:50Z

+		"http://www.hibernate.org/dtd/hibernate-configuration-3.0.dtd">
+<hibernate-configuration>
+    <session-factory>
+        <!--<property name="hibernate.connection.driver_class">com.mysql.jdbc.Driver</property> -->


We can remove the commented-out mysql lines.

@KevinGilmore Done.

KevinGilmore · 2017-04-10T12:56:11Z

+<!DOCTYPE hibernate-reverse-engineering PUBLIC "-//Hibernate/Hibernate Reverse Engineering DTD 3.0//EN" "http://hibernate.sourceforge.net/hibernate-reverse-engineering-3.0.dtd" >
+
+<hibernate-reverse-engineering>
+  <table-filter match-catalog="db1" match-name="suppliers"/>


@KevinGilmore as commented for hbm we dont need this file anymore and hence removed.

hibernate5-multitenancy Conflicts: pom.xml Also code clean up done.

KevinGilmore

Please see comments in individual files for details.

KevinGilmore · 2017-04-13T00:24:34Z

+            Transaction transaction = currentSession.getTransaction();
+            transaction.begin();
+//            currentSession.createSQLQuery("DROP ALL OBJECTS;").executeUpdate();
+            currentSession.createCriteria(Suppliers.class).list().stream().forEach(System.out::println);


the createCriteria method is deprecated

KevinGilmore · 2017-04-13T00:25:35Z

+        System.out.println("Init DB1");
+        Transaction transaction = db1Session.getTransaction();
+        transaction.begin();
+        db1Session.createSQLQuery("DROP ALL OBJECTS").executeUpdate();


the createSQLQuery method is deprecated

@KevinGilmore well since we are using legacy config method (SessionManager) for boostrapping against the EntityManager, we will have to use this functions though deprecated as of now for multitenancy example. As there is no documentation of how to do that with entitymanager bootstrapping method.

OK, thanks for the explanation.

KevinGilmore · 2017-04-13T00:28:19Z

@@ -0,0 +1,38 @@
+package com.baeldung.hibernate;


Delete this class

@KevinGilmore done.

KevinGilmore · 2017-04-13T00:30:51Z

@@ -0,0 +1,73 @@
+package com.baeldung.hibernate;


Let's move this class to src/test/java

@KevinGilmore done.

KevinGilmore · 2017-04-13T00:32:37Z

+
+    private static SessionFactory makeSessionFactory(ServiceRegistry serviceRegistry) {
+        MetadataSources metadataSources = new MetadataSources( serviceRegistry );
+        for(Class annotatedClasses : getAnnotatedClasses()) {


I'm not fluent in Java 8 streaming API, but if there is way to leverage it here, let's do so.

@KevinGilmore we can do that but will have to convert array results given by getAnnotedClasses() to list and then use stream. So I thought to keep it as it is. What do you feel ?

I don't feel strongly about it, but it may come up again in a higher-level review.

pivovarit · 2017-05-03T07:23:45Z

                <configuration>
                    <executable>maven</executable>
-
+        <module>hibernate5</module>


@KevinGilmore @joshiparthin Why is this here?

joshiparthin added 8 commits February 10, 2017 19:47

First commit for Hibernate 5 Multitenancy tutorial

4650aa0

Changes to fix the code.

61c67c9

Added hibernate begin transaction code.

51bd6c3

Changes to solve the multitenancy issue.

b760228

Changes to integrate h2

639b6cf

Changing configs to solve the error

6870481

Changes to solve h2 error...

b2df4bc

Changes to fix H2 error.

4af7903

KevinGilmore suggested changes Apr 1, 2017

View reviewed changes

Cleaned POM.xml and changed entity name

917f958

KevinGilmore reviewed Apr 8, 2017

View reviewed changes

Changes table name to supplier

0056eb0

KevinGilmore suggested changes Apr 10, 2017

View reviewed changes

joshiparthin added 2 commits April 11, 2017 16:20

Merge remote-tracking branch 'upstream/master' into

8088761

hibernate5-multitenancy Conflicts: pom.xml Also code clean up done.

Removed MySql Dep from pom.xml.

ccdd18d

KevinGilmore suggested changes Apr 13, 2017

View reviewed changes

Changes as per comment in the PR...

eb3fdbc

KevinGilmore approved these changes Apr 20, 2017

View reviewed changes

KevinGilmore merged commit 76673a3 into eugenp:master Apr 20, 2017

pivovarit reviewed May 3, 2017

View reviewed changes

Conversation

joshiparthin commented Feb 10, 2017

Uh oh!

KevinGilmore left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinGilmore left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinGilmore left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KevinGilmore left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment