Skip to content

JAVA-18167 Upgrade persistence-modules to JDK 11#13714

Merged
dkapil merged 20 commits into
eugenp:masterfrom
timis1:JAVA-18167
Apr 7, 2023
Merged

JAVA-18167 Upgrade persistence-modules to JDK 11#13714
dkapil merged 20 commits into
eugenp:masterfrom
timis1:JAVA-18167

Conversation

@timis1

@timis1 timis1 commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

Migrate the persistence-modules to the jdk9 and above profile

Comment thread persistence-modules/pom.xml
Comment thread pom.xml
<module>messaging-modules</module>

<module>persistence-modules/questdb</module>
<module>vaadin</module>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing vaadin as part of this PR?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back. In my commit wasn't show me that was deleted.

@dkapil dkapil merged commit 101fc1b into eugenp:master Apr 7, 2023
@mariuszdb

Copy link
Copy Markdown
Contributor

Hi @timis1 , I'm adding changes in persistence-modules/hibernate-jpa and the integration tests aren't run by the CI job. Check my draft PR here: #13848. I think this might be due persistence-modules being in default-jdk9-and-above profile which excludes integration tests and/or CI misconfiguration.

You also upgraded Spring Boot to 3+, which requires at least JDK 17 https://spring.io/blog/2022/05/24/preparing-for-spring-boot-3-0#upgrade-to-java-17 so java version 17 should be explicitly set in the pom.

I don't have access to the JIRA issues you're working on, so I don't know the big picture of these changes. Letting you know and sending an email to support in hope of getting my tests to run in the CI 😅 .

@timis1

timis1 commented Apr 17, 2023

Copy link
Copy Markdown
Contributor Author

Hi @timis1 , I'm adding changes in persistence-modules/hibernate-jpa and the integration tests aren't run by the CI job. Check my draft PR here: #13848. I think this might be due persistence-modules being in default-jdk9-and-above profile which excludes integration tests and/or CI misconfiguration.

You also upgraded Spring Boot to 3+, which requires at least JDK 17 https://spring.io/blog/2022/05/24/preparing-for-spring-boot-3-0#upgrade-to-java-17 so java version 17 should be explicitly set in the pom.

I don't have access to the JIRA issues you're working on, so I don't know the big picture of these changes. Letting you know and sending an email to support in hope of getting my tests to run in the CI 😅 .

Hi @mariudotsh,
Sorry for late response. Looks like you added a new example in the hibernate-jpa. Yes, I think it will be useful to explicitly set the java version 17 since the minimum required version is 17.
My task was related to upgrade all the articles from persistence-modules migrate the default-jdk9-and-above and on this way we migrated also to the hibernate 6.

@mariuszdb

Copy link
Copy Markdown
Contributor

@timis1 Thanks for the reply. I just found in the docs that "- that’s because unit tests run in the standard build; integration and live tests do not" so I'm assuming this is intended. Sorry for the trouble.

pingm26 pushed a commit to pingm26/tutorials that referenced this pull request May 6, 2026
* JAVA-18167 Upgrade persistence-modules to JDK 11 (activejdbc and core-java-persistence)

* JAVA-16167 Update pom.xml to include just the updated modules

* JAVA-18167 Added vaadin because it looks that I removed

* JAVA-18167 Migration deltaspike

* JAVA-18167 Migration hbase module

* JAVA-18167 Migration hibernate-mapping-2

* JAVA-18167 Migration hibernate-exceptions

* JAVA-18167 Migration hibernate-jpa module

* JAVA-18167 Migration hibernate-jpa change the name of User entity

* JAVA-18167 Overwriting the version of slf4j and logback for hibernate-jpa

* JAVA-18167 Migrate deltaspike back to jdk8

* JAVA-18167 Remove some modules that was added elsewhere

* Revert "JAVA-18167 Migration deltaspike"

This reverts commit 874b4ba

* JAVA-18167 Comment failed module (it will be migrated later)

---------

Co-authored-by: timis1 <noreplay@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants