Update h2 version for core-java-lang-oop-modifiers#13786
Closed
ehsansasanian wants to merge 1 commit into
Closed
Conversation
|
|
||
| <properties> | ||
| <h2.version>1.4.197</h2.version> <!-- needs to be specified as it fails with parent's 1.4.200 --> | ||
| <h2.version>2.1.214</h2.version> <!-- needs to be specified as it fails with parent's 1.4.200 --> |
Contributor
There was a problem hiding this comment.
Please remove the comment
| public void whenConnectingToH2_connectionInstanceIsReturned() throws SQLException { | ||
|
|
||
| final String url = "jdbc:h2:~/test"; | ||
| final String url = "jdbc:h2:mem:test"; |
Contributor
There was a problem hiding this comment.
let's use the filesystem db, not the in-memory one.
Contributor
Author
There was a problem hiding this comment.
It's already done in the new PR. #13976
Closing this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.