Skip to content

Java 15032 #13913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkapil merged 3 commits into from
May 1, 2023
Merged

Java 15032 #13913

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
856d4c1
JAVA-15032: Changes made for adding the test cases custom userAgent i…
Bipinkumar27 Apr 26, 2023
4128c1a
JAVA-15032: Changes made for adding the test cases custom userAgent i…
Bipinkumar27 Apr 26, 2023
c353169
JAVA-15032: Changes made for incorporarting review comments
Bipinkumar27 May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions httpclient-simple/src/test/java/com/baeldung/httpclient/HttpClientHeadersLiveTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,26 +25,22 @@ class HttpClientHeadersLiveTest {

@Test
void whenClientUsesCustomUserAgent_thenCorrect() throws IOException {
final HttpGet request = new HttpGet(SAMPLE_URL);

try (CloseableHttpClient client = HttpClients.custom()
final CloseableHttpClient client = HttpClients.custom()
.setUserAgent("Mozilla/5.0 Firefox/26.0")
.build()) {
.build();
final HttpGet request = new HttpGet(SAMPLE_URL);

String response = client.execute(request, new BasicHttpClientResponseHandler());
logger.info("Response -> {}", response);
}
String response = client.execute(request, new BasicHttpClientResponseHandler());
logger.info("Response -> {}", response);
}

@Test
void whenRequestHasCustomUserAgent_thenCorrect() throws IOException {
CloseableHttpClient client = HttpClients.createDefault();
final HttpGet request = new HttpGet(SAMPLE_URL);
request.setHeader(HttpHeaders.USER_AGENT, "Mozilla/5.0 Firefox/26.0");

try (CloseableHttpClient client = HttpClients.createDefault()) {
String response = client.execute(request, new BasicHttpClientResponseHandler());
logger.info("Response -> {}", response);
}
String response = client.execute(request, new BasicHttpClientResponseHandler());
logger.info("Response -> {}", response);
}

@Test
Expand Down