Bael 817#2411
Merged
Merged
Conversation
KevinGilmore
suggested changes
Aug 18, 2017
KevinGilmore
left a comment
KevinGilmore
left a comment
Contributor
There was a problem hiding this comment.
The module does not compile. Please check the comments on the pom.xml and the test class.
| @@ -1,531 +1,395 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | |||
Contributor
There was a problem hiding this comment.
This module seems to be missing some dependencies that were recently added from other articles. Make sure you pull down the upstream changes into your repository, commit them, and push.
Also, please change the indentation back to spaces instead of tabs. There should be an easy way to do this in your IDE. As it is now, it looks like every line of the file has changed, so it's difficult to see what the real changes are.
| import org.junit.Test; | ||
| import org.opengis.feature.simple.SimpleFeatureType; | ||
|
|
||
| public class BuiltFeaturesTest { |
Contributor
There was a problem hiding this comment.
Let's rename this class to GeoToolsUnitTest (the "UnitTest" part is a naming convention).
KevinGilmore
approved these changes
Aug 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.