BAEL-1041 Introduction to Caffeine#2585
Merged
Merged
Conversation
Conflicts: spring-core/src/main/java/com/baeldung/value/ValuesApp.java
Conflicts: libraries/pom.xml
Conflicts: libraries/pom.xml
Conflicts: libraries/pom.xml
Conflicts: libraries/pom.xml libraries/src/main/java/com/baeldung/awaitility/AsyncService.java libraries/src/test/java/com/baeldung/awaitility/AsyncServiceUnitTest.java
Conflicts: libraries/pom.xml
| public class CaffeineUnitTest { | ||
|
|
||
| @Test | ||
| public void given_Cache_whenPopulate_thenValueStored() { |
Contributor
There was a problem hiding this comment.
Several of the test names begin with "given_".
Let's remove the trailing underscore. So this one, for example, would just be:
"givenCache_whenPopulate_thenValueStored"
|
|
||
| String key = "A"; | ||
| DataObject dataObject = cache.getIfPresent(key); | ||
| assertNull(dataObject); |
Contributor
There was a problem hiding this comment.
Always add a blank line between what is being tested and the assertion(s).
Conflicts: libraries/pom.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.